docs(session): анализ навигации и find-references для членов через вывод типов#4197
Open
nixel2007 wants to merge 3 commits into
Open
docs(session): анализ навигации и find-references для членов через вывод типов#4197nixel2007 wants to merge 3 commits into
nixel2007 wants to merge 3 commits into
Conversation
…вод типов Заметки по диагностике F12/hover на ИмеетТип (asserts) и дизайну индексации type-inferred member-обращений для find-references/rename. Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01KZQafLUdXJF7ZDqphzs6tX
Contributor
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: Organization UI Review profile: CHILL Plan: Pro Run ID: 📒 Files selected for processing (1)
WalkthroughAdds a new session-notes document describing the F12 failure for type-inferred members, a minimal definition fix, an eager type-coordinate indexing design for references and rename, invalidation scenarios, a draft feature plan, and a file-role map. ChangesDesign notes: type-inferred member navigation
Estimated code review effort🎯 1 (Trivial) | ⏱️ ~5 minutes Poem
🚥 Pre-merge checks | ✅ 5✅ Passed checks (5 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. ✨ Finishing Touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
![coderabbitai[bot]](https://avatars.githubusercontent.com/in/347564?s=60&v=4){kind=small}
Contributor
There was a problem hiding this comment.
Actionable comments posted: 1
🤖 Prompt for all review comments with AI agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.
Inline comments:
In
@.session-notes/goto-definition-and-find-references-for-type-inferred-members.md:
- Around line 85-87: The fenced code block in the markdown note is missing a
language tag and triggers markdownlint MD040. Update the unlabeled fence in the
referenced note to include a language label such as text, keeping the existing
content and formatting otherwise unchanged.
🪄 Autofix (Beta)
Fix all unresolved CodeRabbit comments on this PR:
- Push a commit to this branch (recommended)
- Create a new PR with the fixes
ℹ️ Review info
⚙️ Run configuration
Configuration used: Path: .coderabbit.yaml
Review profile: CHILL
Plan: Pro
Run ID: 85ec4003-9632-451a-bc1b-abceceb0c791
📒 Files selected for processing (1)
.session-notes/goto-definition-and-find-references-for-type-inferred-members.md
Comment on lines
+85
to
+87
| ``` | ||
| resolve символ под курсором → referenceIndex.getReferencesTo(symbol) | ||
| ``` |
Contributor
There was a problem hiding this comment.
📐 Maintainability & Code Quality | 🟡 Minor | ⚡ Quick win
Add a language tag to the fenced block to satisfy markdownlint.
Line 85 uses an unlabeled fenced block; add a language (for example, text) to resolve MD040.
Suggested patch
-```
+```text
resolve символ под курсором → referenceIndex.getReferencesTo(symbol)</details>
<!-- suggestion_start -->
<details>
<summary>📝 Committable suggestion</summary>
> ‼️ **IMPORTANT**
> Carefully review the code before committing. Ensure that it accurately replaces the highlighted code, contains no missing lines, and has no issues with indentation. Thoroughly test & benchmark the code to ensure it meets the requirements.
```suggestion
🧰 Tools
🪛 markdownlint-cli2 (0.22.1)
[warning] 85-85: Fenced code blocks should have a language specified
(MD040, fenced-code-language)
🤖 Prompt for AI Agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.
In
@.session-notes/goto-definition-and-find-references-for-type-inferred-members.md
around lines 85 - 87, The fenced code block in the markdown note is missing a
language tag and triggers markdownlint MD040. Update the unlabeled fence in the
referenced note to include a language label such as text, keeping the existing
content and formatting otherwise unchanged.
Source: Linters/SAST tools
Contributor
…бственного кода Уточнение случая №3: типы-определения это в первую очередь код проекта (правится постоянно), не редко меняющиеся библиотеки. Разложил правки B на тело/переименование/ смену сурфейса — инвалидирует только последнее; dependency-инвалидатор узкий и хирургический. rename требует инвалидации обязательно, find-references допускает best-effort. Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01KZQafLUdXJF7ZDqphzs6tX
Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01KZQafLUdXJF7ZDqphzs6tX
|
pull Bot
pushed a commit
to bia-technologies/bsl-language-server
that referenced
this pull request
Jun 25, 2026
…вол дескриптора F12 на члене платформенного/конфигурационного типа, разрешённом через TypeService.memberAt в синтетический PlatformMemberSymbol (например, метод OneScript-класса в fluent-цепочке asserts: Ожидаем.Что(X).ИмеетТип(...)), не срабатывал: DefinitionProvider отсекал такие ссылки фильтром isSourceDefinedSymbolReference, хотя дескриптор уже несёт source-defined символ-источник (OScriptModuleMembersProvider.withSourceSymbol). Добавлен маленький Reference->Reference map (unwrapPlatformMemberSource), разворачивающий ссылку на источник перед фильтром; основной пайплайн перехода не меняется. Платформенные члены без источника остаются hover-only. Обсуждение и дизайн: 1c-syntax#4197 Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01KZQafLUdXJF7ZDqphzs6tX
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Заметки по диагностике F12/hover на ИмеетТип (asserts) и дизайну индексации
type-inferred member-обращений для find-references/rename.
Co-Authored-By: Claude Opus 4.8 noreply@anthropic.com
Claude-Session: https://claude.ai/code/session_01KZQafLUdXJF7ZDqphzs6tX